Refactor H5 publishing into local_h5 services#723
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5ebed95 to
6ab9cef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #722.
This refactors the production US local-area and national H5 publishing path into a testable
local_h5library surface with thin adapters around it.What Changed
policyengine_us_data/calibration/local_h5/with:build_h5(...)into a compatibility facade over the new builder/writer pathcalibration_package.pklinstead of regenerating from seed in the production Modal pathdocs/internals/local_h5_refactor_status.mdTest Coverage
Added targeted coverage for the new components and adapter seams, including:
tests/unit/test_pipeline_validation_diagnostics.pybuild_h5(...)integration seam test intests/integration/test_build_h5_minimal.pyRecent focused runs:
Boundary Notes
This PR intentionally changes a few adapter-layer behaviors:
calibration_package.pklso production publishing uses exact package geographyfingerprint.jsonis now a structured record, though it still preserves the digest fieldvalidation_errors.jsonin addition to the regional CSV / national text outputThe old standalone
publish_local_area.pyloops remain mostly intact as a non-production boundary. The one-area build path beneath them is refactored; the outer standalone iteration/checkpoint/upload flow is largely left alone.Follow-Ups
ValidationPolicyis only partially enforced today; onlyenabledis fully wired