Populate CPS inputs for SPM childcare formula#705
Conversation
baogorek
left a comment
There was a problem hiding this comment.
I realize this is an early review and we're waiting on policyengine-us#7960, but I wanted to get some thoughts in here. Interesting that the tests are failing on state-level calibration of aca. (I need to add that to my scorecard.)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Addressed the review comments in 27169f8:
Local checks:
Note: |
|
Follow-up for the unit-test failure on the new run: 89b58ac extracts The CI failure came from the test calling the full
|
|
Integration follow-up: the Modal run failed in I pushed a narrow fix in this commit:
Local verification:
|
Summary
WKSWORKthrough the microdata build asweeks_workedspm_unit_capped_work_childcare_expensesinsidepolicyengine-us-datapolicyengine-usand add regression coverage for the new input plumbingValidation
uv run pytest -q tests/unit/test_extended_cps.py tests/unit/test_weeks_worked.pyuv run ruff check policyengine_us_data/datasets/cps/extended_cps.py tests/unit/test_extended_cps.py tests/unit/test_weeks_worked.pygit diff --checkNotes
SPM_WKXPNSis highly reproducible from other CPS inputs: MAE is about$12,97.9%of units are within$1, and99.1%are within$5.SPM_CAPWKCCXPNSis not reproducible nearly as cleanly from current public CPS inputs, so this PR intentionally stops short of reconstructing the capped value inus-data.