Add ACA marketplace plan selection proxies#618
Conversation
baogorek
left a comment
There was a problem hiding this comment.
Hi @daphnehanse11 , I'm going to let my Claude do the talking below, but the short of it is that there's a lot to do. I think Codex went for the quick win, and there's just not a quick win here.
the CMS data sourcing is thorough and the underlying goal of decomposing PTC into used vs. unused makes sense. However, I think
the approach needs to be restructured. The matrix builder should stay generic and not contain variable-specific logic, and the variables you're deriving
don't yet exist in the places they need to for calibration to actually work.
Here's the full path I'd suggest, roughly in dependency order:
1. policyengine-us: Add used_aca_ptc, unused_aca_ptc, and selects_bronze_marketplace_plan as real calculated variables with formulas and parameters. The
state-level bronze selection probabilities and price ratios from your CMS data become parameters there. Everything downstream depends on these existing
first.
2. ETL scripts (policy_data.db): Derive state-level calibration targets (e.g., total used PTC by state) from the CMS data and load them into the targets
database. That's where calibration targets live now.
3. enhanced_cps.py: Wire up the bronze plan selection so the legacy calibration pipeline has access to the new variables.
4. target_config.yaml: Add the new variable names so the unified matrix builder picks them up — no code changes to the builder itself, just config.
With this approach, the matrix builder never needs to know what these variables are. It just sees new names in the config and new rows in the database, same
as any other target.
I'd suggest starting with step 1 since everything else depends on it.
New "under construction" node type (amber dashed) for showing pipeline changes that are actively being developed: US: - PR #611: Pipeline orchestrator in Overview (Modal hardening) - PR #540: Category takeup rerandomization in Stage 2, extracted puf_impute.py + source_impute.py modules in Stage 4 - PR #618: CMS marketplace data + plan selection in Stage 5 UK: - PR #291: New Stage 9 — OA calibration pipeline (6 phases) - PR #296: New Stage 10 — Adversarial weight regularisation - PR #279: Modal GPU calibration nodes in Stages 6, 7, Overview Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
New "under construction" node type (amber dashed) for showing pipeline changes that are actively being developed: US: - PR #611: Pipeline orchestrator in Overview (Modal hardening) - PR #540: Category takeup rerandomization in Stage 2, extracted puf_impute.py + source_impute.py modules in Stage 4 - PR #618: CMS marketplace data + plan selection in Stage 5 UK: - PR #291: New Stage 9 — OA calibration pipeline (6 phases) - PR #296: New Stage 10 — Adversarial weight regularisation - PR #279: Modal GPU calibration nodes in Stages 6, 7, Overview Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-plan-selection # Conflicts: # policyengine_us_data/calibration/unified_matrix_builder.py # policyengine_us_data/storage/calibration_targets/README.md # tests/unit/test_aca_marketplace_plan_selection_proxies.py # tests/unit/test_aca_marketplace_targets.py # tests/unit/test_marketplace_plan_selection.py
baogorek
left a comment
There was a problem hiding this comment.
@daphnehanse11 I'm requesting that this PR be refocused to the targets ETL and perhaps the ECPS logic. Please note that that this current PR will not affect the ECPS because it's not touching either loss.py or enhanced_cps.py. I don't think your coding agent was able to pick up on the two distinct paths.
I cannot approve the changes in unified_matrix_builder.py or publish_local_area.py. and I recommend that they be removed from the PR. Hard-coded variables in the matrix builder are what made the junkyard the junkyard. We need to do everything humanly (or codexly) possible to never, ever hard-code a variable in unified_matrix_builder.py.
It is possible that publish_local_area.py will need a small modification before this works in local area calibration. Once these targets are in, we can start building models locally and test out the changes. So, I really think this needs to be a two part process.
So if you want the ECPS to be improved, which will get you a benefit now, there needs to be a separate editing of loss.py or enhanced_cps.py in this PR. In that case, some CSVs are acceptable in the storage/calibraiton folder. If you only want better local area h5 calibration, then there should not be CSVs at all, with the exception of sources are not available for download online (like our national "Tips" target). Please see etl_medicaid.py for reference.
Note: the meaning of "ETL" is
E: Extract from the original source
T: Transform the data
L: Load the data into the database.
Forgive me from being tough on this PR: the target sourcing is excellent work. There is just a lot of risk in modifying some of these files.
Summary
This PR adds ACA marketplace plan-selection proxies to the calibration pipeline.
It introduces a simple bronze-vs-benchmark selection layer that can be used to model households leaving part of the benchmark-based ACA credit unused when they choose a cheaper bronze plan.
Concretely, this PR:
policyengine_us_data/storage/calibration_targetsmarketplace_plan_selectionhelper for seeded bronze-vs-benchmark assignmentpublish_local_area.pyunified_matrix_builder.pyNew derived outputs
This PR adds calibration-side / published-data support for:
selected_marketplace_plan_premium_proxyused_aca_ptcunused_aca_ptcPublished tax-unit inputs now also include:
selects_bronze_marketplace_planselected_marketplace_plan_benchmark_ratiostate_marketplace_bronze_probabilitystate_marketplace_bronze_to_benchmark_ratioData sources and fallbacks
The proxy builder uses 2024 CMS marketplace public use files where available.
For missing SBM price menus, the derived state ratio table carries an explicit state-specific fallback with provenance columns (
source,source_year,source_basis) so the fallback is visible rather than hidden in code.Validation
Automated tests:
pytest policyengine_us_data/tests/test_marketplace_plan_selection.py policyengine_us_data/tests/test_aca_marketplace_plan_selection_proxies.py -qpytest policyengine_us_data/tests/test_calibration/test_unified_matrix_builder.py -qSmoke test:
selected_marketplace_plan_premium_proxy,used_aca_ptc, andunused_aca_ptcused_aca_ptc + unused_aca_ptc == aca_ptcheld exactly in the published H5 auditNotes
This PR is additive plumbing. It does not:
policyengine-usA follow-up rules PR in
policyengine-uscan expose the new tax-unit variables as first-class model variables.