Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
corporate_land_valueusing the current weighted distribution ofcorporate_wealthinstead of a stale corporate-wealth parameter totalpolicyengine-uk-dataWhy
household_land_valueis already on the newer regional-intensity path, butcorporate_land_valuewas still being scaled byaggregate_corporate_land_value / household.wealth.corporate_wealth.That made the result depend on an out-of-sync parameter total rather than the actual weighted corporate-wealth distribution in the dataset. In local measurement on
enhanced_frs_2023_24for 2025, that left corporate land materially high versus the ONS target.With this change, local weighted aggregates moved to:
household_land_value:£4.737tncorporate_land_value:£2.058649tnland_value:£6.796tnThe key fix is the corporate component: it now matches the
policyengine-uk-dataONS corporate-land target level exactly instead of drifting above it.Testing
uv run pytest -q policyengine_uk/tests/test_corporate_land_value.py policyengine_uk/tests/test_parameter_metadata.pyuvx ruff check policyengine_uk/variables/household/wealth/corporate_land_value.py policyengine_uk/tests/test_corporate_land_value.py