Fix residual detection in aggregate_microdata#34
Merged
nikhilwoodruff merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
The residual check was cancelling out legitimate benunit-level benefit changes. When a post-hook modifies reform_universal_credit on benunits but not reform_net_income on households, the old logic computed a negative residual that subtracted the benefit increase. Now only applies the residual when household net_income actually changed, trusting the program-level columns otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The residual check in
aggregate_microdatawas cancelling out legitimate benunit-level benefit changes. When a post-hook modifiesreform_universal_crediton benunits but doesn't touchreform_net_incomeon households, the old logic computed a negative residual that subtracted the benefit increase back out.Now only applies the residual adjustment when household
net_incomeactually changed, trusting the program-level column sums otherwise. Also removes unused variables.