Generate simulation telemetry envelopes for Modal requests#3405
Merged
Generate simulation telemetry envelopes for Modal requests#3405
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3405 +/- ##
==========================================
+ Coverage 72.97% 73.06% +0.09%
==========================================
Files 56 56
Lines 2598 2629 +31
Branches 460 463 +3
==========================================
+ Hits 1896 1921 +25
- Misses 617 622 +5
- Partials 85 86 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3404
Summary
_telemetryenvelope alongside the existing_metadatapayload for Modal simulation submissionsrun_id,process_id, geography classification, config hash, requested timestamp, andtraceparentwhen availablerun_idthrough the Modal client response object and submission/error logs without regressing current bundle metadata behaviorValidation
uv run ruff check policyengine_api/libs/simulation_api_modal.py policyengine_api/services/economy_service.py tests/fixtures/libs/simulation_api_modal.py tests/fixtures/services/economy_service.py tests/unit/libs/test_simulation_api_modal.py tests/unit/services/test_economy_service.pyuv run pytest --noconftest tests/unit/libs/test_simulation_api_modal.py