Repository navigation
feat!: rename to PoliNetwork eSign and publish Linux packages for Arch, Debian and Fedora - #7
Merged
Conversation
…h, Debian and Fedora The project is now PoliNetwork eSign (github.com/PoliNetworkOrg/esign): app and package names, the macOS bundle identifier, the polinetwork-esign:// link scheme, the configuration and install folders, the release files and the page's postMessage type all change. Installing eSign removes what PoliNetwork Sign Agent v0.1.x registered (login item or service, link handler, installed copy, running agent) and moves its configuration folder; the .deb replaces the polinetwork-sign-agent package. Linux: every release also builds an .rpm and an Arch package next to the .deb. The packages depend on pcsc-lite and the CCID driver under each distribution's names, enable pcscd.socket, and start the agent for the users logged in. preremove.sh no longer disables the service when rpm upgrades the package. Stable releases publish: - polinetwork-esign-bin to the AUR (scripts/aur-package.sh, packaging/aur/PKGBUILD); - signed APT and DNF repositories on GitHub Pages (scripts/linux-repository.sh), which the .deb and .rpm add, so the agent updates with the system. Both are skipped with a warning until their keys exist: scripts/setup-linux-publishing.sh, docs/linux-packages.md. BREAKING CHANGE: the link scheme is polinetwork-esign:// and the page posts "pn-esign"; the dashboard must follow.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe pull request renames PoliNetwork Sign Agent to PoliNetwork eSign across the application, installers, packages, and documentation. It adds cleanup of legacy installations, expands Linux package outputs, and adds stable-release publishing for APT, DNF, and AUR. ChangeseSign identity and distribution
Sequence Diagram(s)sequenceDiagram
participant Tag as Stable release tag
participant Workflow as Release workflow
participant Repository as linux-repository.sh
participant Pages as GitHub Pages
participant AUR as AUR
Tag->>Workflow: Start release jobs
Workflow->>Repository: Build signed APT and DNF repositories
Workflow->>Pages: Upload and deploy repository artifact
Workflow->>AUR: Build and push package update
Priority: ➖ Normal Change: Feature Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 59.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 66 functions across 50 files. (30 skipped… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely summarizes the two primary changes: renaming the application to PoliNetwork eSign and publishing Linux packages for Arch, Debian, and Fedora. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 59.09% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 66 functions across 50 files. (30 skipped: 16 unsupported, 14 over the file limit.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the project to PoliNetwork eSign and makes Arch, Debian/Ubuntu and Fedora supported Linux targets, with packages that update along with the system.
Rename
The repository is now
PoliNetworkOrg/esign(GitHub redirects the old URLs). The rename covers the Go module,cmd/esign, the app name, the binaries (esign,esign.exe,polinetwork-esign), the macOS bundle IDorg.polinetwork.esign, the link schemepolinetwork-esign://, the config and install folders, the release file names, theESIGN_*test env vars and the page's postMessage typepn-esign.Migration from v0.1.x:
install(and opening the app) removes what PoliNetwork Sign Agent registered: login item or service, link handler, "Installed apps" entry and installed copy. It also stops a running old agent, so the two don't compete for port 47321.config.Dirmoves the old config folder, with its card pairings, to the new location..debreplacespolinetwork-sign-agent.Dashboard counterpart: PoliNetworkOrg/admin#106.
Linux packages
.deb, an.rpmand an Arch.pkg.tar.zstwith nfpm. Dependencies use each distro's names (pcscd/pcsc-lite/pcsclite plus the CCID driver).pcscd.socket(Arch leaves it off by default) and starts the agent for users who are logged in.polinetwork-esign-bin(packaging/aur/PKGBUILD,scripts/aur-package.sh), so Arch users can install withyay -S polinetwork-esign-binorparu.scripts/linux-repository.sh). The.deband.rpmadd these repositories, so after one manual install the agent updates throughapt upgradeordnf upgrade.scripts/setup-linux-publishing.sh; seedocs/linux-packages.md.Testing
go vet. actionlint passes on the workflows..debreplaced the real v0.1.1 package. A running per-user v0.1.1 install was migrated: the new agent took over port 47321 and the config folder moved.