Repository navigation
test(autostart): keep the Linux tests away from an agent installed on the machine - #12
Merged
Merged
Conversation
… the machine TestInstalledParsesEntries redirected XDG_CONFIG_HOME but still read the package's unit in /usr/lib/systemd/user and its global enablement in /etc/systemd/user, so on a machine with the agent installed Installed() found it and the test failed. The tests now point those paths at a temporary directory too, and a new test covers the package unit, which counts only once enabled for every user.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestInstalledParsesEntriesfails on any Linux machine where the agent is installed from the package:The test points
XDG_CONFIG_HOMEat a temporary directory, butInstalled()also reads the package's unit (/usr/lib/systemd/user/polinetwork-esign.service) and its global enablement (/etc/systemd/user/default.target.wants/…). With the package installed, it finds them and reports the agent as installed before the test has written anything. The code is right; the test was not isolated from the machine.isolate(t)points the user config directory and the package unit paths (systemUnits,globalEnabled) at temporary directories, and restores them after the test.TestInstalledPackageUnit: the package unit counts as installed only once enabled for every user.Test-only change.
go test ./...passes on a machine with the agent installed.