[lorenzocorallo]

Why

The suite took ~6.6 s locally (~15.6 s in CI). Most of that was waiting, not testing. A few tests also repeated coverage that other tests already provide.

Speed

• src/trpc.ts: the timing middleware adds a 100–200 ms delay to every call when tRPC's isDev is set. isDev is true for any NODE_ENV except production, so test got the delay too. It now runs only when env.NODE_ENV === "development". Development and production behave as before.
  • azure-router 6.0 s → 0.26 s, idp-policy 3.2 s → 3 ms, idp-router 3.2 s → 1.2 s (what's left is the import of the app router).
• tests/seed-db.test.ts: beforeAll did a full seed (~1.9 s), but beforeEach truncates every table right after. The tests only needed the migrated schema, so beforeAll now imports @/db, which applies the migrations (~0.3 s). This file is the slowest one in CI.

Measured locally: the suite without the DB went from 6.6 s to 1.8 s, and seed-db from 14.6 s to 10.5 s (run-to-run noise included).

Removed tests (each one checks something another test already covers)

• cipher › has stable payload format: the IV is always zero, so the pinned DETERMINISTIC_PAYLOAD already fixes the format.
• tg-users-creation-history › is limited to token callers…: this checked the policy through a mocked dashboard(). idp-router asserts the real policy of tg.users.getCreationHistory, including the scope and tokenOnly.
• azure-router › the two stale snapshot cases: they only made the mocked has() return false. That is the same code path as the no permission cases, because nothing in the router reads status().
• azure-router › the addMember assertion with member permissions: the member permissions alone case of the it.each makes the same check with the same context.

Checks

• bun run typecheck and biome ci pass
• Full suite passes, with seed-db run against a fresh Postgres 18 on an empty schema

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 84ccbecc-c4f2-47e6-8f7a-4a4046456b6e

📥 Commits

Reviewing files that changed from the base of the PR and between 5867df6 and 722a707.

📒 Files selected for processing: 5

• src/trpc.ts
• tests/azure-router.test.ts
• tests/cipher.test.ts
• tests/seed-db.test.ts
• tests/tg-users-creation-history.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}