Skip to content

feat: Implement public access to group data and manage hidden groups visibility - #85

Merged
toto04 merged 2 commits into
mainfrom
feat/groups-search-public-read
Oct 21, 2026
Merged

toto04 merged 2 commits into
mainfrom
feat/groups-search-public-read

Conversation

@BIA3IA

@BIA3IA BIA3IA commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Enable public access to group data while ensuring hidden groups remain visible only to authorized users. Adjustments made to the search functionality reflect these access controls.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c8fd2e0c-522a-41d9-837a-4ee1c7c1ae79
📥 Commits

Reviewing files that changed from the base of the PR and between bc082e6 and 4fa3b0b.

📒 Files selected for processing: 4
  • src/idp/policies.ts
  • src/routers/groups/search.ts
  • src/routers/tg/groups.ts
  • tests/idp-router.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Group listing and search routes now use actor-based permissions to control hidden-group visibility. Tests cover route access and visibility for website tokens, dashboard users, anonymous actors, and service tokens.

Changes

Group Visibility

Layer / File(s) Summary
Actor-based group visibility
src/idp/policies.ts, src/routers/groups/search.ts, src/routers/tg/groups.ts
Adds seesHiddenGroups, which returns true for anonymous actors and users. Group routes use this policy to filter hidden groups. The IDP listing and search routes use publicData.
Group search access tests
tests/idp-router.test.ts
Expands the database query mock and tests website-token access, hidden-group filtering, dashboard and anonymous visibility, and rejection of service tokens without backend:public:read.

Priority: ⬇️ Low

Change: Feature

Merge Risk: ⚪ Minimal · up to 4fa3b

The change makes group listing and search available to public-data callers and keeps hidden groups restricted for website tokens. No actionable merge-blocking risk was found.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly describes the main changes: public group-data access and hidden-group visibility controls.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo
lorenzocorallo force-pushed the feat/groups-search-public-read branch from 3801c6d to 5115f89 Compare October 20, 2026 21:43
@BIA3IA
BIA3IA requested a review from toto04 October 21, 2026 09:50
@toto04
toto04 merged commit 946ac1a into main Oct 21, 2026
2 checks passed
@toto04
toto04 deleted the feat/groups-search-public-read branch October 21, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants