Repository navigation
feat(web): manage freshman page content - #84
Merged
Merged
Conversation
Renumber the freshman content migration from 0022 to 0026, after the e-signing migrations 0022-0025 now on main. Its schema statements were regenerated with drizzle-kit from main's snapshots and are unchanged; the data statements are carried over as they were.
This was referenced Oct 20, 2026
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe change adds fixed-slot Freshman content storage and initialization, public content retrieval, protected editing procedures, and safeguards for featured FAQs. Unit and PostgreSQL integration tests cover validation, access, concurrent operations, and deletion behavior. ChangesFreshman content
Sequence Diagram(s)sequenceDiagram
participant DashboardEditor
participant webRouter
participant freshmanRouter
participant PostgreSQL
DashboardEditor->>webRouter: Submit selectFaq input
webRouter->>freshmanRouter: Route protected mutation
freshmanRouter->>PostgreSQL: Lock featured slots and validate selection
PostgreSQL-->>freshmanRouter: Current FAQ selections
freshmanRouter->>PostgreSQL: Swap or update selected FAQ
PostgreSQL-->>freshmanRouter: Updated selection
freshmanRouter-->>DashboardEditor: Return mutation result
Priority: ➖ Normal Change: Feature Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 12 files. (3 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: adding management for freshman page content in the web application. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 12 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
toto04
approved these changes
Oct 21, 2026
toto04
force-pushed
the
main
branch
2 times, most recently
from
October 21, 2026 19:43
e989be7 to
43854c5
Compare
#88 removed the legacy author argument from authorOf, so freshman writes now use tokenOnly policies like the other web content mutations. The legacy modifiedBy input is still accepted and ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
web.freshman(getContent, updateCard, moveCard, selectFaq) and migration0026_freshman_content, which creates the card slots and featured FAQ positions and seedsthem with the current website content (reusing matching FAQs from the catalog).
web:content:writefor edits.FEATURED_FAQ.Note:
tests/esign-service.test.tsfails on main as well (fixed clock 2026-10-17 vs acertificate valid from "yesterday"); unrelated to this PR.