Repository navigation
feat(esign): choose which roles and permissions may use each drive - #76
Merged
Merged
Conversation
Each drive can name the roles and permissions allowed to request signatures with it (browse it, use its PDFs and folders, see its requests) and to be asked to sign its documents. Any listed role or permission grants it; an empty rule keeps today's default. Requests record the drives they use (backfilled by migration 0025), so visibility, signer choice and signing follow the rules. esign.drive.access and esign.drive.setAccess, gated by esign:drives:manage, read and change them.
…snapshot Uses @polinetwork/auth-kit 1.2.0: drive rules match the user's effective roles, and Signatures › Drives lists the IdP's roles and permissions. A signer who lost access to a drive can't upload a signed copy either.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lorenzocorallo
marked this pull request as ready for review
October 17, 2026 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-drive access for e-signing (companion: admin PR; needs PoliNetworkOrg/auth#62 and PoliNetworkOrg/auth-kit#2).
esign_drive_access: for each drive, a request rule (browse it, use its PDFs/folders in a request, see its requests) and a sign rule (be chosen as signer, sign, upload a signed copy). A rule lists roles and permissions; holding any one grants it. Empty rule = today's default (esign:requests:manage/ everyone who signs).drivesthey use (source and output; migration 0025 backfills existing ones). Visibility (list all,get, documents),config.drives, drive browsing/import, request creation (signers must qualify), starting a signature and the signed-upload fallback all follow the rules.esign.drive.access/esign.drive.setAccessgated by the new IdP permissionesign:drives:manage.index.roles(),index.catalog()).Draft:
@polinetwork/auth-kitis bumped to ^1.2.0, which is published when auth-kit#2 merges; then refreshbun.lock.Checks: 123 tests (new: rules by role and by permission, default restore, visibility, signer choice, lost access), Postgres smoke extended (drive access upsert), migration tested on a database with requests (backfill incl. cross-drive), tsc, biome.