Skip to content

fix: "Create" button will submit the form for new members#44

Merged
toto04 merged 1 commit into
mainfrom
toto04/fix-create-member
Jul 5, 2026
Merged

fix: "Create" button will submit the form for new members#44
toto04 merged 1 commit into
mainfrom
toto04/fix-create-member

Conversation

@toto04

@toto04 toto04 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

how the fuck did we not notice before lmao

how the fuck did we not notice before
@toto04 toto04 requested a review from lorenzocorallo July 5, 2026 18:23
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6385f3a2-dab4-427a-98e1-ae04583e5340

📥 Commits

Reviewing files that changed from the base of the PR and between c39a6f4 and a100b42.

📒 Files selected for processing (1)
  • src/app/dashboard/(active)/azure/members/create-assoc-member.tsx

Walkthrough

The Create button in the CreateAssocUser component's sheet footer now explicitly sets type="submit", while retaining its existing disabled state and pending-dependent label text.

Changes

Create Button Fix

Layer / File(s) Summary
Explicit submit type on Create button
src/app/dashboard/(active)/azure/members/create-assoc-member.tsx
The "Create" button now explicitly declares type="submit", keeping the existing disabled={pending} state and conditional "Saving..."/"Create" label text.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main fix: making the Create button submit the new member form.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo

Copy link
Copy Markdown
Member

Credo che ci sia stato un default type="button" che ha silenziosamente rotto il behaviour di questo button in particolare che probabilmente prima si basava su type="submit" come default.
In ogni caso, fix sacrosanto LGTM

@toto04 toto04 merged commit ba09a88 into main Jul 5, 2026
2 checks passed
@toto04 toto04 deleted the toto04/fix-create-member branch July 5, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants