Repository navigation
feat(esign): delete finished signature requests - #118
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Managers get a Delete request action on a completed, cancelled or declined request, through the backend's new esign.requests.delete (@polinetwork/backend 1.11.0). In-progress requests are cancelled first, and a pending delivery hides the action. After deleting, the page goes back to the requests list before reloading the loaders, since reloading the detail page would look the deleted request up again.
lorenzocorallo
force-pushed
the
t3/add-delete-action
branch
from
October 17, 2026 17:35
91d20d3 to
70494de
Compare
BIA3IA
pushed a commit
that referenced
this pull request
Oct 20, 2026
Managers get a Delete request action on a completed, cancelled or declined request, through the backend's new esign.requests.delete (@polinetwork/backend 1.11.0). In-progress requests are cancelled first, and a pending delivery hides the action. After deleting, the page goes back to the requests list before reloading the loaders, since reloading the detail page would look the deleted request up again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Delete request action to the request page. Before this, a completed request had no way to be removed.
esign:requests:manageusers on completed, cancelled and declined requests. An in-progress request still shows Cancel request and must be cancelled first. Hidden while a delivery is pending.ConfirmDialogwarns that signers, activity and every document version are deleted too. It suggests downloading the PDF first, or says the OneDrive copy stays when there is one.deleteEsignRequestserver function behindesignRequestsManageMiddleware, callingesign.requests.deletefrom feat(esign): let managers delete finished requests backend#82 (bumps@polinetwork/backendto 1.11.0). Listed intests/server-security.test.mjs.router.invalidate({ sync: true }). ANOT_FOUNDis treated as already deleted.pnpm check,pnpm typecheck,pnpm testandpnpm buildpass. Not checked in a running app: no local backend was available.