Repository navigation
feat(esign): choose which roles and permissions may use each drive - #109
Merged
Merged
Conversation
Signatures › Drives (esign:drives:manage) shows each drive with two rules, Request signatures and Be asked to sign, made of roles and permissions from the IdP. Empty rules keep the default. On a new request, signers who may not sign the chosen drives' documents are left out, with the reason; the backend filters drives and requests.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 13
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lorenzocorallo
marked this pull request as ready for review
October 17, 2026 12:12
BIA3IA
pushed a commit
that referenced
this pull request
Oct 20, 2026
) * feat(esign): choose which roles and permissions may use each drive Signatures › Drives (esign:drives:manage) shows each drive with two rules, Request signatures and Be asked to sign, made of roles and permissions from the IdP. Empty rules keep the default. On a new request, signers who may not sign the chosen drives' documents are left out, with the reason; the backend filters drives and requests. * build(deps): use @polinetwork/backend 1.10.0 for drive access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard side of per-drive access (backend PR linked in PoliNetworkOrg/backend; roles from PoliNetworkOrg/auth#62 via auth-kit#2).
esign:drives:manage): a card per drive with Request signatures and Be asked to sign rules. Chips for roles (people icon) and permissions (key icon), an inline picker listing the IdP's roles and permissions, "Default: …" while empty, Save/Discard per drive; keys the IdP no longer knows show as warning chips.esign:drives:manageadded; middlewareesignDrivesManageMiddlewareregistered in the security test.Checked:
pnpm check,typecheck,test,build; headless browser against the local backend: restricting Archive to Socio removed it from a Direttivo user's drive picker; restricting who signs Archive left nobody eligible and explained it; rules reset after.Draft until the backend release, then bump
@polinetwork/backend.