Repository navigation
feat(esign): several places per signer and signing several documents with one PIN - #105
Merged
Merged
Conversation
…with one PIN A signer can sign a document in several places, each a full signature or a mark of the first one. The person appears once everywhere: their places are buttons under their name, whose menu switches the kind, moves or removes the place and rings its box on the page. "Sign N together" in To sign opens the waiting documents in a strip to check one by one, then one agent window and one PIN sign them all. The request page offers it when other documents wait, and Sign with CIE follows several jobs, showing each document's result. Needs the backend release with places and batch jobs (backend#75) and sign-agent v0.2.0 (sign-agent#6).
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A signer with several places who uploads a PDF signed with the official app completes their part with one signature, leaving the other places empty.
lorenzocorallo
marked this pull request as ready for review
October 17, 2026 10:37
# Conflicts: # docs/design.md # src/features/esign/sign-with-cie.tsx
BIA3IA
pushed a commit
that referenced
this pull request
Oct 20, 2026
…with one PIN (#105) * feat(esign): several places per signer and signing several documents with one PIN A signer can sign a document in several places, each a full signature or a mark of the first one. The person appears once everywhere: their places are buttons under their name, whose menu switches the kind, moves or removes the place and rings its box on the page. "Sign N together" in To sign opens the waiting documents in a strip to check one by one, then one agent window and one PIN sign them all. The request page offers it when other documents wait, and Sign with CIE follows several jobs, showing each document's result. Needs the backend release with places and batch jobs (backend#75) and sign-agent v0.2.0 (sign-agent#6). * feat(esign): warn that the upload fallback adds a single signature A signer with several places who uploads a PDF signed with the official app completes their part with one signature, leaving the other places empty. * build(deps): use @polinetwork/backend 1.9.0 for places and batch jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard side of PoliNetworkOrg/backend#75 and PoliNetworkOrg/esign#6.
Several places per signer, the person shown once
Signature · p. 2,Mark · p. 1) and Add place (click on the page). A place's menu switches Full signature / Mark only, moves it or removes it, and rings its box on the PDF; the last full signature can't become a mark. Boxes of one person share their number; marks are dashed.Several documents with one PIN
/dashboard/esign/sign: a strip of the documents (toolbar row); opening one marks it checked, each can be left out, and the primary action is Next document until all are checked, then Sign N documents.Checked:
pnpm check,typecheck,test,buildagainst the backend branch's built types. In the browser with the dev agent (software key only): created a request with a signature + a mark, signed it together with another document in one agent window → both completed, PDF valid with the mark drawn; a request with two full signatures → two valid PDF signatures, one signed event.Backend#75 is released as @polinetwork/backend 1.9.0, used here. The upload fallback now warns signers with several places that it adds a single signature.