Replace Boost filesystem with C++17 std::filesystem#6405
Open
kai-waang wants to merge 4 commits intoPointCloudLibrary:masterfrom
Open
Replace Boost filesystem with C++17 std::filesystem#6405kai-waang wants to merge 4 commits intoPointCloudLibrary:masterfrom
kai-waang wants to merge 4 commits intoPointCloudLibrary:masterfrom
Conversation
…d cleanup cmake C++17 related checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6403 has dropped support for C++14, so
std::filesystemis now avaliable by default in PCL. As discussed in #5881,boost::filesystemwas kept because of C++14 compatibility. So this PR:Boost::filesystemfrompcl_find_boost.cmakePCL_PREFER_BOOST_FILESYSTEM.Boost::filesystemoutofcoretopcl_fsand nowpcl_fsis equal tostd::filesystemSome codes still have boost/filesystem or boost::filesystem usage.
pcl/outofcore/boost.h,pcl/visualization/boost.h: includes<boost/filesystem.hpp>. But these two header files are not used in PCL.pcl/outofcore/impl/octree_base_node.hpp 2021:2172, but these codes are wrapped by#if 0, and may be removed by another PR.