Enable delayed loading of VTK libraries on Windows#5642
Open
CSBVision wants to merge 2 commits intoPointCloudLibrary:masterfrom
Open
Enable delayed loading of VTK libraries on Windows#5642CSBVision wants to merge 2 commits intoPointCloudLibrary:masterfrom
CSBVision wants to merge 2 commits intoPointCloudLibrary:masterfrom
Conversation
Contributor
|
You can omit using VTK entirely if you build PCL yourself. But I guess it doesn't hurt to do be able to delayload it as an option anyways. |
Contributor
Author
|
Might be true, thanks for pointing out, we did not test this at all because to our knowledge VTK is a mandatory dependency. Even though it can be omitted, it is still extremely useful during development or for debugging purposes, i.e. we don't want to exclude it from the build. Here, delay load allows to use it only where needed, but to skip it elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, VTK is a relatively large but mandatory dependency of PCL. However, it is mostly (if not only) needed for visualization/debugging/etc. such that a significant amount of library functionalities are actually independent of VTK. Still, VTK libraries will always be required since they are a link-time dependency even though they might be not used at all in many applications. For this reasoning, we propose to make the VTK libraries delay loaded on Windows using the
/DELAYLOADlinker option. This allows to skip the VTK modules while distributing PCL, which makes the distribution process relatively lightweight (in particular, if the other dependencies are statically linked).The respective changes are rather small, after VTK was found only the respective linker flags are defined.