Drop most CUDA apps, as they are never built.#5528
Open
SunBlack wants to merge 1 commit intoPointCloudLibrary:masterfrom
Open
Drop most CUDA apps, as they are never built.#5528SunBlack wants to merge 1 commit intoPointCloudLibrary:masterfrom
SunBlack wants to merge 1 commit intoPointCloudLibrary:masterfrom
Conversation
Contributor
|
I think I would leave the apps up for a rewrite. Ie. many of the apps show how the cuda libraries could/can be used, which could be of good value, if one where to try to change the apps to become opencv/ros/kinect independent and more generalized as tools/apps. By quickly skimming, ros was mostly used for publishing. Actual 2d image manipulation should ofc not be implemented in PCL. Those part of the apps would have to be removed, but then still some of the PCL functionality could maybe still be of use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems some apps never were added to a CMakeLists and even the uncommented code for some other apps was already removed some years ago: d58aeaa. As most of the now removed apps depends on legacy OpenCV, it makes no sense to somehow reactivate them (see #5521).
One app still exists after this MR, as
kinect_viewer_cudawill be still built when CUDA is enabled (could be moved to apps directory in a separate PR).