Add spaday-based model registry browser - #249
Draft
timkpaine wants to merge 6 commits into
Draft
Conversation
Contributor
Test Results 1 files ± 0 1 suites ±0 3m 5s ⏱️ +45s Results for commit f548c2e. ± Comparison against base commit a224a37. This pull request removes 67 and adds 129 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 93.57% 93.60% +0.02%
==========================================
Files 176 190 +14
Lines 20500 21175 +675
Branches 1352 1392 +40
==========================================
+ Hits 19183 19820 +637
- Misses 1046 1074 +28
- Partials 271 281 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 12:55
7624af2 to
9a5bcec
Compare
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 20:33
9a5bcec to
de7f4da
Compare
timkpaine
force-pushed
the
tkp/spaday
branch
2 times, most recently
from
August 19, 2026 20:41
238dc5a to
a40c136
Compare
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 22:23
de7f4da to
06586d8
Compare
timkpaine
force-pushed
the
tkp/lazy-registry
branch
from
August 19, 2026 23:06
06586d8 to
03eac9c
Compare
Collaborator
|
@timkpaine IS this ready for review yet? |
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Replace the hand-built wa-tree with spaday-trees, which derives the hierarchy from registry paths and brings its own search box. Add a Dependencies tab rendering the registry dependency DAG with spaday-dagre; clicking a node selects that model, so the graph shares the sidebar's selection state. Registered names are root-relative and leading-slashed, so they are normalized before matching leaf paths. Bridge the tree's color-scheme to the wa-dark page theme and add a dark toggle. Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
timkpaine
commented
Aug 26, 2026
|
|
||
| add_hydra_config_args(parser) | ||
|
|
||
| parser.add_argument("--address", type=str, default="127.0.0.1", help="Address to bind the server to (default: 127.0.0.1).") |
timkpaine
commented
Aug 26, 2026
timkpaine
left a comment
Member
Author
There was a problem hiding this comment.
dagre rendering a bit messed up, also its global and not model-local so it looks a bit weird
materializing a model collapses the tree, need to fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.