Skip to content

Rewrite of MCLC#124

Closed
PadowYT2 wants to merge 98 commits intoPierce01:masterfrom
CreateLumina:master
Closed

Rewrite of MCLC#124
PadowYT2 wants to merge 98 commits intoPierce01:masterfrom
CreateLumina:master

Conversation

@PadowYT2
Copy link
Copy Markdown

@PadowYT2 PadowYT2 commented Mar 11, 2024

This Pull Request has a lot of changes

  • Usage of
    • Typescript (which translates into ESM and CJS during building)
    • Vitest
    • ESLint
    • Prettier
    • Yarn (instead of npm)
  • Many functions were completly remade to work with TS and just function
  • Removed Auth functions

There are still things to finish, such as

  • Config
  • Tests
  • README
  • GitHub workflows
    • Vitest
    • Prettier

@PadowYT2 PadowYT2 marked this pull request as ready for review May 7, 2024 21:00
@PadowYT2
Copy link
Copy Markdown
Author

Looking back at this, I realized that making a launcher in NodeJS isn't a great idea. Tauri would be a better solution here and there are libraries that already exist (not trying to advertise)! Even if you want to keep using NodeJS, there's new tech by now and most of the packages used can be improved.

I'll be closing this PR as I'm not looking forward into making a launcher as of right now and most likely never in NodeJS. The code itself is kinda a mess if you try to actually read/edit it. In theory, the fork should still work, but some updates should be done from upstream.

👋

@PadowYT2 PadowYT2 closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants