Repository navigation
feat: add thinking-orbs family - #38
Merged
Merged
Conversation
Wrap thinking-orbs 0.3.2 (MIT) as dlc.thinking_orbs: one Orb component with nine dotted-sphere canvas states (working, searching, solving, listening, connecting, weaving, composing, breathing, shaping), registered on the dlc.Loading registry. - rate maps to upstream speed, playing to paused = !playing - size is any pixel size: upstream draws 64, 32 or 20 and throws on anything else, so the nearest design is drawn and the canvas scaled to size - color tints the ink (hex or rgb() only, upstream's parser); unset keeps the stock monochrome. dots and dot_size pass through - theme="auto" mirrors Mantine's data-mantine-color-scheme onto the wrapper, since upstream only reads data-theme or a dark/light class, then the OS - gallery: family page with live controls, paused-frame pixel check that each control changes the canvas, orbs kept out of the header brand mark, family icon in search results - CONTRIBUTING: list the steps hit while adding a canvas family
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wraps thinking-orbs 0.3.2 (MIT) as
dlc.thinking_orbs: oneOrbcomponent with nine dotted-sphere canvas states (working,searching,solving,listening,connecting,weaving,composing,breathing,shaping), registered on thedlc.Loadingregistry like loadersz.How the gaps in the issue turned out:
coloris supported upstream. The issue says there is no color prop; 0.3.x has one (#rgb,#rrggbborrgb(), depth shading kept on the tint). It is passed through, and left unset keeps the stock monochrome ink. Other CSS color syntax is ignored by upstream ("orange"stays grey); documented in the prop docs, README and gallery copy. The gallery color field starts empty so a page shows whatOrb()renders.sizeis any pixel size. Upstream has three designs (64, 32, 20; the 32 is interpolated and untuned) and throws on any other size. The wrapper draws the nearest design by ratio and scales the canvas tosizewith CSS. Default 64. Sizes above 64 upscale the 64 design and soften. Tested for 12 to 256.theme="auto"does not see Mantine. Upstream reads an ancestordata-themeordark/lightclass, then the OS; Mantine setsdata-mantine-color-schemeon<html>, which upstream never looks at. Verified in the gallery: the orbs followed the OS, not the toggle. The wrapper now mirrors that attribute onto its owndata-themewhile it is present, so auto follows a dmc color scheme toggle live (tested with the OS in the other mode). Without Mantine nothing changes: OS, as upstream.rateis upstreamspeed,playing=Falseispaused, plusdots,dot_size,aria_label. Upstream'sopts,frameandgravityare not exposed.Gallery: live controls on every page (each shown to change a paused frame's pixels), the orbs kept out of the animated header brand mark, family icon in header search rows (a canvas orb cannot be cloned or created from
gallery.js). The family has no categories, so the sidebar list is flat.CONTRIBUTING's "Adding a family" now lists the steps this needed beyond the old list (package
__init__.py,index.js, webpack exclude, tree-shaking check, counts, canvas test and mark steps).Closes #34
Checklist
feat:/fix:/perf:/revert:(if this should ship in the next PyPI release) orchore:/docs:/ci:/test:/style:/refactor:(if not)