Repository navigation
fix: a checkout is a built source tree only when the compiled module is there - #71
Merged
Merged
Conversation
…is there, not when the type stubs are
The validation workers (build123dftc, cadqueryftc) put the checkout's src on their subprocess's path only when it is a
built tree, because it would shadow the installed wheel with Python files that have no compiled module. They looked for
glob('_native*'), which the new type stub directory src/simplecadapi/_cpp/_native/ matches: in the release workflow's wheel
tests (the wheel installed, the checkout not built) six tests failed with 'simplecadapi needs its compiled C++ module'.
wheel_smoke.py asserted the same glob, which the stubs would have satisfied without the extension.
All three now require a file. A test pins the rule (stubs alone: not built; .so / .pyd: built).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…evelopment build, false in CI's editable install) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the release dry run of 2.2.7: in the wheel tests (the wheel installed, the checkout not built) six tests failed with "simplecadapi needs its compiled C++ module". The validation workers add the checkout's
srcto their subprocess path only when it is a built tree, and decided that withglob("_native*"), which the type stub directorysrc/simplecadapi/_cpp/_native/(added in #68) matches.src/cpp/tests/wheel_smoke.pyasserted the same glob and would have passed without the extension.All three places now require a file.
test/test_source_tree_is_built.pypins the rule.🤖 Generated with Claude Code