Repository navigation
feat(verify): OCP for verifier scripts through simplecadapi.verify; drop the fem extra - #67
Merged
Merged
Conversation
…cripts; drop the fem extra shape.wrapped is the SDK's own binding, so OCP functions reject it and verifier scripts that did BRepGProp.VolumeProperties_s(solid.wrapped, ...) stopped working with the C++ engine. simplecadapi.verify.to_ocp / from_ocp bridge through OpenCASCADE's binary format; the verify extra installs OCP 7.9 without VTK. The SDK itself never imports OCP. The skill gets references/discipline/verifier-scripts.md, whose code the tests execute. The fem extra (gmsh, ccx2paraview[VTK]) is removed with the README steps that used it; vtk is out of the lock file. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
NiJingzhe
added a commit
that referenced
this pull request
Oct 29, 2026
…shape PR #67's test_the_sdk_wrapped_shape_is_not_an_ocp_shape asserted that OCP rejects shape.wrapped; with OCP installed wrapped is now an OCP shape (a deliberate change of this branch). The original assertion is kept for the SDK's own binding (SCA_WRAPPED=native), and a new test pins the new default: OCP measures solid.wrapped. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing OCP from the SDK made verifier scripts hard to write:
shape.wrappedis now the SDK's own binding, and OCP functions reject it (incompatible function arguments). The repo's ownsandbox-envs/desktop_arm_sources/check_*.pystopped importing.simplecadapi.verify.to_ocp/from_ocpbridge through OpenCASCADE's binary format (a few ms per part); the SDK itself still never imports OCP.verifyextra:cadquery-ocp-novtk>=7.9.3.1,<8(sameOCPimport, no VTK;<8because OCP 8 renames the casts and changes signatures).references/discipline/verifier-scripts.md(the.wrappedtrap, recipes, a verifier skeleton). The tests execute the page's code.femextra and the README steps using it are removed; VTK is out of the lock file.Checked: for the 34 parts of the six-axis arm, volumes and bounds measured through OCP agree between 2.2.6 (native OCP) and this engine (bridged): volume <= 1.7e-9 relative, bounds <= 2.3e-12 mm.
🤖 Generated with Claude Code