Skip to content

Partially reopen #1335 ExtendedBuildingPlacing and AutoUpgrade - #2470

Open
Coronia wants to merge 7 commits into
Phobos-developers:developfrom
Coronia:extend-building-placing
Open

Coronia wants to merge 7 commits into
Phobos-developers:developfrom
Coronia:extend-building-placing

Conversation

@Coronia

@Coronia Coronia commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

Restore 2 features from #1335 since there's a high demand of it from players, and hopefully make it easier to be reviewed

Building placing and deploying logic enhancement

  • In vanilla games, buildings are always cannot placing or deploying on the cells that other infantries or units on. Now this can be changed by setting ExtendedBuildingPlacing to true, when you try to place the building on these cells, it will check whether the occupiers can be scatter by yourself (include your own technos and allies technos) and whether there are enough spaces to scatter. If can, it will record which building you are placing and show a preview to you and your allies, then start a timer to record this placement and order the occupiers to leave this building area. When the area is cleared, the building will be truly place down and the production queue will be restored to original state. But when the timer expires or an unexpected situation has occurred which make the building impossible be constructed here anymore, it will stop the action and play "cannot deploy here", then you should re-place or re-deploy the building in a valid space.
  • AutoUpgrade controls whether building upgrades can be automatically placed on the correct and earliest built building.

In rulesmd.ini:

[General]
ExtendedBuildingPlacing=false   ; boolean

[SOMEBUILDING]                  ; BuildingType
AutoUpgrade=false               ; boolean

@Coronia Coronia added ❓New feature Tested ⚙️T1 T1 maintainer review is sufficient labels Oct 15, 2026
@Coronia Coronia changed the title Partially reopen #1335 'ExtendBuildingPlacing and AutoUpgrade` Partially reopen #1335 ExtendBuildingPlacing and AutoUpgrade Oct 15, 2026
@Coronia Coronia changed the title Partially reopen #1335 ExtendBuildingPlacing and AutoUpgrade Partially reopen #1335 ExtendedBuildingPlacing and AutoUpgrade Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Coronia
Coronia requested a review from NetsuNegi October 15, 2026 02:51
Comment thread src/Ext/BuildingType/Body.cpp Outdated
Comment thread src/Ext/BuildingType/Body.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
@Coronia
Coronia requested a review from NetsuNegi October 16, 2026 06:51
Comment thread src/Ext/BuildingType/Body.cpp Outdated
Comment thread src/Ext/BuildingType/Body.cpp Outdated
Comment thread src/Ext/BuildingType/Body.cpp Outdated
Comment thread src/Ext/BuildingType/Body.cpp Outdated
Comment thread src/Ext/BuildingType/Body.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Comment thread src/Ext/BuildingType/Hooks.Placing.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❓New feature ⚙️T1 T1 maintainer review is sufficient Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants