Stop immediately if the target enters the range during ApproachTarget#2088
Stop immediately if the target enters the range during ApproachTarget#2088TaranDahl wants to merge 6 commits intoPhobos-developers:developfrom
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
The The |
|
given there were quite a lot of controversial for our previous tag renaming (such as new Trajectory and the recent major renaming), I think we should still stick to the principal of no tag name change unless necessary. For this PR I think we don't have to depreciate those AttackMove tag, could just redirect their implementaion to the new one. |
I don't think we should keep something that is incorrect. This is not a simple tag renaming. They are removed because the function itself is incorrect. |
DeathFishAtEase
left a comment
There was a problem hiding this comment.
Changelog entry position error
Co-authored-by: Noble Fish <89088785+DeathFishAtEase@users.noreply.github.com>
Co-authored-by: Noble Fish <89088785+DeathFishAtEase@users.noreply.github.com>
…hTarget_StopMovingWhenInRange
|
I see that it has already added the Tested label and is not a draft, so should this PR already be in a completed state?
The documentation for the discarded INI flag and its related content does not seem to have been removed yet, which should also be part of the pending work for this PR, because I see that they have already been removed in the changes to the source code. |

Stop immediately if the target enters the range during ApproachTarget
In
rulesmd.ini: