This repository was archived by the owner on Oct 9, 2025. It is now read-only.
Fix 'Cannot read properties of undefined (reading 'map')' error in deploy command#58
Open
dmvt wants to merge 1 commit intoPhala-Network:mainfrom
Open
Fix 'Cannot read properties of undefined (reading 'map')' error in deploy command#58dmvt wants to merge 1 commit intoPhala-Network:mainfrom
dmvt wants to merge 1 commit intoPhala-Network:mainfrom
Conversation
…ploy command - Fixed crash when envs is undefined by adding null check: envs ? envs.map(...) : [] - Added defensive handling for nodes and kms_list data structure variations - Added null checks for target.images to prevent similar undefined access issues - Resolves deployment failures caused by missing environment file parameter The deploy command now properly handles cases where no environment file is provided, allowing deployments to proceed correctly instead of crashing with undefined errors.
Leechael
reviewed
Oct 2, 2025
| const nodes = nodes_result.data as any; | ||
| const nodesData = nodes_result.data as any; | ||
| // Handle both possible data structures | ||
| const nodes = nodesData.nodes || nodesData; |
Collaborator
There was a problem hiding this comment.
that's not a safe operation.
| const kms_list = kms_result.data as any; | ||
| const kmsData = kms_result.data as any; | ||
| // Handle both possible data structures | ||
| const kms_list = kmsData.items || kmsData; |
Collaborator
There was a problem hiding this comment.
that's not a safe operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The deploy command was crashing with "Cannot read properties of undefined (reading 'map')" when no environment file was provided, preventing users from deploying CVMs.
Root Cause
The
validateEnvFile()function returnsundefinedwhen no environment file is provided, butdeployNewCvm()unconditionally calledenvs.map()without null checking.Solution
envs ? envs.map((env) => env.key) : []Testing
Impact
This fix restores the core functionality of the deploy command, allowing users to deploy TEE applications without crashes when no environment file is specified.