fix(runtime): grow large pre-sized arrays densely (rebased, from #9376) - #9434
Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #9376, rebased onto current
main. Author's work preserved; the rebase resolution was done by a codex agent I ran on it, and I verified the result independently rather than accepting its report.Why it needed a rebase. #9376's base predates #9370's reapply of #9297, so it targeted a shape of
array/indexing.rsthat no longer exists. It deletedDENSE_ARRAY_GAP_LIMIT,array_sparse_index_property_getandarray_sparse_index_property_set, which have 11 references on currentmain, several inside the restored prototype-chain code.The resolution keeps both behaviours rather than picking one: the three symbols move to the existing
array/indexing_support.rsinstead of being deleted, and dense frontier growth now runs only after the inherited-accessor and non-writable checks — so #9297/#9370's owner walk still happens first.What I verified myself, not from the agent's summary:
indexing_support.rs, i.e. moved rather than deleted.--no-raise-vsclean, plus file-size, root-holder, census, thread-local and unrooted-local.test_gap_9220_9221_array_proto_paths.tsbyte-identical to the pinned Node 26.5.1 oracle using the agent's own build — that is the fixture that would catch the owner walk being lost.The agent reported
perry-runtime2,929 passed / 0 failed and both fixtures matching node; the checks above are my independent confirmation of the parts that matter.