test(parity): drop the stale test_stress_promises known-failure entry

[proggeramlug]

parity (10) fails the stale-entry check on candidate 83754818ea:

STALE known_failures.json entries — these tests PASS on linux:
  - test_stress_promises

Per #7582, an entry that outlives its bug is not a triage note — it is a permanent suppression of that test's next regression. One entry removed, nothing else touched.

Worth noting this is the first verdict parity (10) has ever produced. It was cancelled on every prior release candidate, so it sat in the set of six jobs that had never completed. It turns out to be a one-line cleanup rather than a blocker.

Recorded uncertainty

#8841 is still open, and no targeted fix for this SIGSEGV appears in main's history — so this may be a bug that is currently masked rather than fixed. The entry claims it reproduced 5/5 on the revisions it was filed against; that cannot be re-verified from macOS, and the gate's Linux verdict is the only current evidence.

I am following the gate's policy rather than second-guessing it, because the failure modes are asymmetric: if the SIGSEGV returns, a red gate is visible and fixable, whereas a stale suppression silently absorbs the next real regression in this test.

If it does return, the right response is a fresh entry against a fresh issue with current evidence — not restoring this one, whose reasoning is two weeks and many merges stale.

Summary by CodeRabbit

• Bug Fixes

  • Updated test validation so the promise stress test is no longer treated as an expected Linux failure.
  • Future regressions in this area will now be detected instead of being silently ignored.

• Documentation

  • Added a changelog entry explaining the updated failure handling and test coverage.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f479fc65-8303-426c-a99a-60f708a72484

📥 Commits

Reviewing files that changed from the base of the PR and between 6642990 and 9538c18.

📒 Files selected for processing (2)

• changelog.d/9286-stale-known-failure.md
• test-parity/known_failures.json

💤 Files with no reviewable changes (1)

• test-parity/known_failures.json

Included review availability: Your plan provides up to 8 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The parity triage configuration removes the Linux known-failure entry for test_stress_promises. A changelog entry records that the test now passes on Linux and that stale entries must be removed.

Changes

Parity known-failure cleanup

Layer / File(s)	Summary
Remove stale test suppression test-parity/known_failures.json, changelog.d/9286-stale-known-failure.md	The Linux-only test_stress_promises ratchet entry is removed. The changelog records the removal and its stale-entry requirement.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9538c

This localized change removes a stale test suppression and documents the cleanup. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the change, rationale, and uncertainty, but it does not follow the required template. It omits the Summary, Changes, Related issue, Test plan, Screenshots / output, and Checkl…	Rewrite the description using the repository template. Add the required section headings, list the concrete changes, identify issue #8841 or mark the PR as standalone, document the test commands and results, and complete the checklist.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the primary change: removing the stale test_stress_promises parity known-failure entry.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the change, rationale, and uncertainty, but it does not follow the required template. It omits the Summary, Changes, Related issue, Test plan, Screenshots / output, and Checklist sections, including test verification details.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/stale-known-failure

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[proggeramlug]

Merged.

Removing a stale entry is a claim that the test now passes, so I checked it rather than taking the CI line — but with an honest limit on what my check proves.

test_stress_promises compiled and ran 3/3 clean, exit 0, output byte-identical to node 26.5.1. That is real evidence the test is healthy, and it is not evidence about the platform that mattered: the entry was platforms: ["linux"] and the recorded failure was a SIGSEGV (exit 139) on linux, while I am on macOS arm64. So my run supports your conclusion without settling it — parity (10) on linux is the authority here, and the candidate output you quoted is what actually justifies the removal.

The #7582 framing is right and worth repeating: an entry that outlives its bug is not a triage note, it is a permanent suppression of that test's next regression. A skip list that only ever grows converges on testing nothing, which is why the stale-entry check has to be able to fail in this direction too.

The observation I'd escalate is your aside, not the diff. If parity (10) "was cancelled on every prior release candidate" and this is the first verdict it has ever produced, then that job has been in the set of checks that cannot go red — the same shape #9256 documents for a cancelled lint. A gate that never runs is absent from the status list, and absent satisfies "nothing is failing" exactly as well as passing does. Worth confirming it now runs reliably rather than assuming this candidate was special, because the next stale entry it would catch is invisible until it does.

Validation: parity_known_failures.py --audit green; perry-runtime 2886 passed / 0 failed; all 60 lint gates. Validated alongside #9283, #9284 and #9288.