[PER-10476] Skip folder fetches for synthetic folders without a folderId

[aasandei-vsp]

Opening /app/shares triggered GET /api/v2/folder?folderIds[]=undefined (500): the sidebar fetched the current folder to get its displayTime, but the Shares workspace is a synthetic FolderVO with no folderId. Guard the sidebar fetch so only folders with a real folderId are requested, and filter invalid ids in FolderRepo.getStelaFolders, skipping the request entirely when none remain.

This is just a small bug that I found, not the full story.

Issue: PER-10476
Subtask: PER-10676

Manual test cases — Shares page folderIds[]=undefined fix need

Shares page load

1. Navigate to /app/shares(make sure you have no shared items) and filter the Network tab(after you inspected the element) by v2/folder.
   • EXPECTED: no request containing folderIds[]=undefined is sent, no 500 response
2. Look at the page content.

Sidebar on the Shares page

1. With nothing selected on /app/shares, open the sidebar.
   • EXPECTED: the sidebar shows the Shares workspace info without triggering any folder request or console error.
2. Click a shared folder in the list.
   • EXPECTED: the sidebar loads its full details (name, date, size) via a request with a real numeric id, e.g. folderIds[]=149939 — never undefined.
3. Click a shared file in the list.
   • EXPECTED: the sidebar loads the record details normally, with no v2/folder request at all.

Regression — My Files

1. Go to /app/private, open any folder, and leave nothing selected so the sidebar shows the current folder.
   • EXPECTED: the sidebar still shows the folder's date; if a fetch is needed it uses the folder's real id in folderIds[].
2. Set a date on a folder via the sidebar, then clear it.
   • EXPECTED: saving and clearing still work; after clearing, the date field shows empty without console errors.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.34%. Comparing base (17c0975) to head (44c4686).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   52.15%   52.34%   +0.19%     
==========================================
  Files         354      354              
  Lines       12090    12094       +4     
  Branches     2186     2187       +1     
==========================================
+ Hits         6305     6331      +26     
+ Misses       5560     5537      -23     
- Partials      225      226       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cecilia-donnelly]

Thank you!