Skip to content

Fix @stela/publisher-utils tests#809

Merged
liam-lloyd merged 1 commit into
mainfrom
noissue_fix_publisher_utils_tests
Jul 24, 2026
Merged

Fix @stela/publisher-utils tests#809
liam-lloyd merged 1 commit into
mainfrom
noissue_fix_publisher_utils_tests

Conversation

@liam-lloyd

Copy link
Copy Markdown
Member

In the recent switch from jest to vitest, we broke our publisher-utils tests. We didn't catch this because our CI wasn't configured to run these tests. This commit fixes the tests and updates the CI to test this package in the future.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.30%. Comparing base (40c7d0d) to head (73ed042).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          93       93           
  Lines        2481     2481           
  Branches      461      461           
=======================================
  Hits         2439     2439           
  Misses         42       42           
Flag Coverage Δ
api 98.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cecilia-donnelly cecilia-donnelly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for catching this @liam-lloyd !

In the recent switch from jest to vitest, we broke our publisher-utils
tests. We didn't catch this because our CI wasn't configured to run
these tests. This commit fixes the tests and updates the CI to test this
package in the future.
@liam-lloyd
liam-lloyd force-pushed the noissue_fix_publisher_utils_tests branch from a25e236 to 73ed042 Compare July 24, 2026 16:51
@liam-lloyd
liam-lloyd merged commit a30f143 into main Jul 24, 2026
36 checks passed
@liam-lloyd
liam-lloyd deleted the noissue_fix_publisher_utils_tests branch July 24, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants