fix: prevent profiler file symlink escapes - #222
Open
shhahbaz wants to merge 1 commit into
Open
Conversation
|
All Contributors have signed the CLA. The PR is now allowed to be merged. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
performanc-bot
added a commit
to PerformanC/CLA-Signatures
that referenced
this pull request
Aug 18, 2026
1Lucas1apk
self-requested a review
August 19, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
realpathbefore reading.distto authoredsrcfallback resolution.Why
The profiler file endpoint already blocked lexical
..traversal, but a symlink located inside the project could point to a file outside the project root. Because filesystem reads follow symlinks, an authorized profiler request could disclose arbitrary local files.This change closes that gap by validating the resolved path before reading it, while keeping the existing behavior unchanged.
Checkmarks
Additional information