Remove forwarding wrapper theorems with no callers - #1107
Merged
Merged
Conversation
Delete 41 declarations whose proof only forwards to another declaration and which nothing in the repository or the downstream workspace projects uses: - renamed or argument-reordered duplicates (strictInterl_shift', deriv_sum_collapse, the Liu--Wang tR aliases, the Set.Iio and right-family restatements, the affine-family _nonneg aliases); - forwarders carrying hypotheses they never use (threshold sine bound, finite Polya--Schur low-degree backward cases, first Branden basis image); - fixed-index instances of normalized_coeff_nonneg_of_isPF; - one-direction halves of hasCommonInterleaver_pair and its left version, and projection aliases of structure fields; - the warmupP compatibility abbrev and its nine mirrored lemmas, and the complexifyLinearMap abbrev (its X_pow simp lemma is restated for complexificationLinearMap); - two Mathlib-folder shims that only restate their hypothesis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the Statement-wrapper cleanup with plain forwarding theorems: declarations whose whole proof applies one other declaration.
Method. A source scan found 575 declarations of this shape on
main. I excluded:Challenges/entry points;SuperEulerian/, or in the downstream workspace projects that import RealRooted (includingreal-rooted-oeis-proofs).I reviewed each remaining candidate by hand and deleted 41:
strictInterl_shift',deriv_sum_collapse, the Liu–WangtRaliases, theSet.Iioand right-family restatements, and the affine-family_nonnegaliases;normalized_coeff_nonneg_of_isPF;hasCommonInterleaver_pairand its left version, plus structure-field projection aliases;warmupPcompatibilityabbrevwith its nine mirrored lemmas, and thecomplexifyLinearMapabbrev. ItsX_powsimp lemma is kept, restated forcomplexificationLinearMap, so simp behaviour is unchanged;Kept on purpose:
isPolyaFreqSeq_of_orderedCertificates;Checks:
lake-workspace build RealRooted.BorceaBranden.Applications.AffineFiniteSymbolpassed (9125 jobs).main.🤖 Generated with Claude Code