Skip to content

Remove forwarding wrapper theorems with no callers - #1107

Merged
PerAlexandersson merged 2 commits into
mainfrom
chore/forwarder-cleanup-1
Oct 5, 2026
Merged

PerAlexandersson merged 2 commits into
mainfrom
chore/forwarder-cleanup-1

Conversation

@PerAlexandersson

Copy link
Copy Markdown
Owner

Continues the Statement-wrapper cleanup with plain forwarding theorems: declarations whose whole proof applies one other declaration.

Method. A source scan found 575 declarations of this shape on main. I excluded:

I reviewed each remaining candidate by hand and deleted 41:

  • renamed or argument-reordered duplicates: strictInterl_shift', deriv_sum_collapse, the Liu–Wang tR aliases, the Set.Iio and right-family restatements, and the affine-family _nonneg aliases;
  • forwarders that carry hypotheses they never use: the threshold sine bound, the finite Pólya–Schur low-degree backward cases, and the first Brändén basis image;
  • fixed-index instances of normalized_coeff_nonneg_of_isPF;
  • one-direction halves of hasCommonInterleaver_pair and its left version, plus structure-field projection aliases;
  • the warmupP compatibility abbrev with its nine mirrored lemmas, and the complexifyLinearMap abbrev. Its X_pow simp lemma is kept, restated for complexificationLinearMap, so simp behaviour is unchanged;
  • two Mathlib-folder shims that only restate their hypothesis.

Kept on purpose:

  • simp and API lemmas about a different constant;
  • worked examples and smoke tests;
  • genuine corollaries;
  • "predicate-face" forms that state a result through the canonical predicate, such as isPolyaFreqSeq_of_orderedCertificates;
  • the public names for PF-sequence tactic internals.

Checks:

  • The only proof change is the restated simp lemma. A focused lake-workspace build RealRooted.BorceaBranden.Applications.AffineFiniteSymbol passed (9125 jobs).
  • Every other change is a deletion with zero remaining references, rechecked after merging current main.
  • Root-import, import-architecture, proof-status and catalog checks pass.
  • The full default build is left to CI.

🤖 Generated with Claude Code

PerAlexandersson and others added 2 commits October 5, 2026 08:55
Delete 41 declarations whose proof only forwards to another declaration
and which nothing in the repository or the downstream workspace projects
uses:

- renamed or argument-reordered duplicates (strictInterl_shift',
  deriv_sum_collapse, the Liu--Wang tR aliases, the Set.Iio and
  right-family restatements, the affine-family _nonneg aliases);
- forwarders carrying hypotheses they never use (threshold sine bound,
  finite Polya--Schur low-degree backward cases, first Branden basis
  image);
- fixed-index instances of normalized_coeff_nonneg_of_isPF;
- one-direction halves of hasCommonInterleaver_pair and its left
  version, and projection aliases of structure fields;
- the warmupP compatibility abbrev and its nine mirrored lemmas, and
  the complexifyLinearMap abbrev (its X_pow simp lemma is restated for
  complexificationLinearMap);
- two Mathlib-folder shims that only restate their hypothesis.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@PerAlexandersson
PerAlexandersson merged commit 668a759 into main Oct 5, 2026
3 checks passed
@PerAlexandersson
PerAlexandersson deleted the chore/forwarder-cleanup-1 branch October 5, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant