Move reference semantics MBQC ops to MBQC dialect#2829
Open
paul0403 wants to merge 4 commits into
Open
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
==========================================
- Coverage 96.95% 96.95% -0.01%
==========================================
Files 169 169
Lines 18869 18875 +6
Branches 1797 1799 +2
==========================================
+ Hits 18295 18300 +5
Misses 409 409
- Partials 165 166 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joeycarter
approved these changes
May 13, 2026
Contributor
joeycarter
left a comment
There was a problem hiding this comment.
Thanks @paul0403 💯
Just had a couple of suggestions to polish up the docs while we're here, otherwise looks good.
Co-authored-by: Joey Carter <joseph.carter@xanadu.ai>
Co-authored-by: Joey Carter <joseph.carter@xanadu.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
When the MBQC reference semantics ops were first added, I added them to the overarching
qrefdialect.This was not the best organization. See discussion in thread
In particular,
As a domain specific dialect, MBQC is now hosting both value and reference semantics ops.
Description of the Change:
Move reference semantics mbqc ops from
qrefdialect tombqcdialect.Benefits:
Better organization.