[Not sketchy] Fix name of stack trace in log capture#195
Open
the-can-of-soup wants to merge 1 commit intoPenguinMod:developfrom
Open
[Not sketchy] Fix name of stack trace in log capture#195the-can-of-soup wants to merge 1 commit intoPenguinMod:developfrom
the-can-of-soup wants to merge 1 commit intoPenguinMod:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Fixes the misleading
Error:text in all log captures.Proposed Changes
Replaces the
Error:text in log captures withStackTrace:. I am like 80% sure I did this right.(I don't know how to properly test it, so in the image above I just copy-pasted the
StackTraceclass with my change and threw an error)Reason for Changes
This makes the log captures less misleading.
Test Coverage
I didn't 🤯
Browser Coverage
Check the OS/browser combinations tested (At least 2)
I have literally no idea how to test this properly so I just threw an error in the console using the modified class
Mac
Windows
Chromebook
iPad
Android Tablet