Skip to content

[Not sketchy] Fix name of stack trace in log capture#195

Open
the-can-of-soup wants to merge 1 commit intoPenguinMod:developfrom
the-can-of-soup:patch-1
Open

[Not sketchy] Fix name of stack trace in log capture#195
the-can-of-soup wants to merge 1 commit intoPenguinMod:developfrom
the-can-of-soup:patch-1

Conversation

@the-can-of-soup
Copy link

Resolves

Fixes the misleading Error: text in all log captures.

image

Proposed Changes

Replaces the Error: text in log captures with StackTrace:. I am like 80% sure I did this right.

image

(I don't know how to properly test it, so in the image above I just copy-pasted the StackTrace class with my change and threw an error)

Reason for Changes

This makes the log captures less misleading.

Test Coverage

Please show how you have added tests to cover your changes

I didn't 🤯

Browser Coverage

Check the OS/browser combinations tested (At least 2)

I have literally no idea how to test this properly so I just threw an error in the console using the modified class

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant