add server storage extension by Ikelene · Pull Request #451 · PenguinMod/PenguinMod-ExtensionsGallery

Ikelene · 2025-12-27T16:30:28Z

idk why it still wants to merge update url and comments (it was already merged)
and i did sync

anyways my new super cool extension is here
server is open source at https://github.com/Ikelene/scratchStorageExtension
thanks

vercel · 2025-12-27T16:30:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
penguinmod-extensions-gallery	Ready	Preview	Jan 28, 2026 6:47pm

Ikelene · 2025-12-27T16:32:20Z

image text dont fit let me fix rq

Steve0Greatness

Sorry for the somewhat long review, but I had a couple thoughts.

Steve0Greatness · 2026-01-04T21:19:24Z

static/extensions/Ikelene/serverStorageExtension.js

+            this.maxDataSize = 262144;
+
+            this.editMode = 'live'; // 'live' or 'local'
+            this.localCache = {};   // { key: value }


Cache is usually supposed to be updated quite a lot, so a regular object is probably the least efficient way to handle this. I'd personally recommend using a Map for caching, instead.

Steve0Greatness · 2026-01-04T21:23:42Z

static/extensions/Ikelene/serverStorageExtension.js

+            this.apiKey = null;
+            this.maxDataSize = 262144;
+
+            this.editMode = 'live'; // 'live' or 'local'


This should be documented in JSDoc so that IDEs know what values it should be. In this case the specific comment you'd want here is /** @type {'live' | 'local'} */. Note that this doesn't have a runtime impact, it's only for development convenience and code documentation.

Steve0Greatness · 2026-01-04T21:29:05Z

static/extensions/Ikelene/serverStorageExtension.js

+
+    class ServerStorage {
+        constructor() {
+            this.serverUrl = 'https://ikelene.dev/storage/';


serverUrl, editMode and apiKey might be wanted to be saved in extension data using the serialization/deserialization APIs, as they're global state.

Steve0Greatness · 2026-01-04T21:37:11Z

static/extensions/Ikelene/serverStorageExtension.js

+                    method: 'POST',
+                    headers: {
+                        'Content-Type': 'application/json',
+                        'Accept': 'application/json'
+                    },
+                    body: JSON.stringify({ apiKey: this.apiKey })


This would require changes to the server, but in general API key sending should be done through headers, such as Authorization using the basic method. If this is done, then the request could instead be sent as using the GET method, which better explains what the actual request is doing.

This also applies to other POST requests that simply send the API key and are used to simply query data.

API key should also be sent in headers of other data posting queries.

I will probably implement this in a future update

Steve0Greatness · 2026-01-04T21:41:18Z

static/extensions/Ikelene/serverStorageExtension.js

+                const result = await res.json();
+                if (!result.success || !Array.isArray(result.keys)) return '[]';
+                return JSON.stringify(result.keys);
+            } catch (e) {


In general, if you're going to ignore values like this, you should set it's name to _. It makes it easier to tell that it's being ignored.

Steve0Greatness · 2026-01-04T22:14:32Z

static/extensions/Ikelene/serverStorageExtension.js

+                console.warn('need api key to download cache');
+                return;
+            }
+            try {


In general, if the function need to be able to perform networking and is unable to, it should be able to error out. Here it makes sense to dump the responsibility to handle it onto the user of the extension.

Steve0Greatness · 2026-01-04T22:20:40Z

static/extensions/Ikelene/serverStorageExtension.js

+                if (response.status === 401) {
+                    return false;
+                }


I'm aware that I've said this a lot, but really don't be afraid to throw errors, especially when there is genuinely something wrong.

Steve0Greatness · 2026-01-04T22:22:53Z

static/extensions/Ikelene/serverStorageExtension.js

+        constructor() {
+            this.serverUrl = 'https://ikelene.dev/storage/';
+            this.apiKey = null;
+            this.maxDataSize = 262144;


Why specifically 2^18 bytes?

So people don't go uploading full image / video data URIs, although it probably should be server-side

Steve0Greatness · 2026-01-04T22:27:07Z

static/extensions/Ikelene/serverStorageExtension.js

+
+                const result = await response.json();
+                if (result.success && result.data) {
+                    return result.data.value || '';


This API is weirdly complicated. You may want to trim back what it sends in the main body a little bit.

Steve0Greatness · 2026-01-04T22:28:24Z

static/extensions/Ikelene/serverStorageExtension.js

+
+            try {
+                const response = await fetch(this.serverUrl + 'delete.php', {
+                    method: 'POST',


There's actually a specific DELETE method made for the exact purpose. It's even allowed to have a request body.

cicerorph · 2026-01-05T07:13:50Z

Btw, just here to say that If you didn't add protection on the php script for setting data, ADD IT, people can just go there and prob find a way to create a php file and run it, and as you know, it gives access to the server, just sayin btw, gn

Ikelene · 2026-01-05T15:42:10Z

Btw, just here to say that If you didn't add protection on the php script for setting data, ADD IT, people can just go there and prob find a way to create a php file and run it, and as you know, it gives access to the server, just sayin btw, gn

All data is stored in a database, not where it uploads a file to the server so that's not possible, unless I'm misunderstanding here on what you mean

cicerorph · 2026-01-05T15:46:09Z

Its bcs I saw it was using php, my fault Em seg., 5 de jan. de 2026, 12:42, [Ikelene] ***@***.***> escreveu:

…

*Ikelene* left a comment (PenguinMod/PenguinMod-ExtensionsGallery#451) <#451 (comment)> Btw, just here to say that If you didn't add protection on the php script for setting data, ADD IT, people can just go there and prob find a way to create a php file and run it, and as you know, it gives access to the server, just sayin btw, gn All data is stored in a database, not where it uploads a file to the server so that's not possible, unless I'm misunderstanding here on what you mean — Reply to this email directly, view it on GitHub <#451 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BD67XLLH5T2ROIFBAAT2U4D4FKA6RAVCNFSM6AAAAACQD67XQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJQHE2TGMZZGU> . You are receiving this because you commented.Message ID: ***@***.***>

Ikelene · 2026-01-05T16:27:52Z

oki i've made most of Steve's change requests in the code, with exceptions to the ones requiring API changes as i cant be bothered to change that right now, it will probably be updated in a later version.

hopefully thats all we need to change and it can be published now 🤞

Ikelene · 2026-01-28T03:32:33Z

Hey can we do something about people placing their extensions at the top of the list? My extension pretty much just got replaced by another one, and that one was out at the very top of the list, making mine obsolete because theirs gets all the exposure and mine will never get seen because who wants to scroll down when an extension that fits their needs is right there. Maybe have it so there's tags for extensions like #auth or #storage etc to sort them and give all extensions equal exposure. Also it's kind of unfair because my extension PR has been open for 3 weeks now and theirs got approved within a day of opening :/

JeremyGamer13 · 2026-01-28T03:38:04Z

Hey can we do something about people placing their extensions at the top of the list?

we reorder the list every now and then but PRs to reorder should be fine too

Maybe have it so there's tags for extensions like #auth or #storage etc to sort them and give all extensions equal exposure.

will be solved by #482

Gen1xLol · 2026-01-28T04:16:21Z

Hey can we do something about people placing their extensions at the top of the list?

we reorder the list every now and then but PRs to reorder should be fine too

Maybe have it so there's tags for extensions like #auth or #storage etc to sort them and give all extensions equal exposure.

will be solved by #482

hey jerm. i honestly did NOT see her PR when i made mine. i placed mine there just bc i was lazy when editing the file

Ikelene · 2026-01-28T18:43:23Z

im just going to sync my branch and readd my extension and stuff to fix the conflict give me a sec

Ikelene · 2026-01-28T18:47:41Z

all fixed

vercel bot deployed to Preview December 27, 2025 16:30 View deployment

vercel bot deployed to Preview December 27, 2025 16:34 View deployment

vercel bot deployed to Preview December 27, 2025 19:08 View deployment

Steve0Greatness suggested changes Jan 4, 2026

View reviewed changes

vercel bot deployed to Preview January 5, 2026 16:25 View deployment

JeremyGamer13 added the new extension This extension is brand new to the repository label Jan 24, 2026

vercel bot deployed to Preview January 28, 2026 15:51 View deployment

vercel bot deployed to Preview January 28, 2026 16:41 View deployment

vercel bot had a problem deploying to Preview January 28, 2026 18:40 Failure

Ikelene closed this Jan 28, 2026

Ikelene force-pushed the main branch from 261dbf3 to 884df01 Compare January 28, 2026 18:44

Ikelene added 3 commits January 28, 2026 11:45

server storage ext

c7049cf

server storage

12b6fc2

server storage

552f951

Ikelene reopened this Jan 28, 2026

vercel bot deployed to Preview January 28, 2026 18:47 View deployment

Conversation

Ikelene commented Dec 27, 2025

Uh oh!

vercel bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ikelene commented Dec 27, 2025

Uh oh!

Steve0Greatness left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cicerorph commented Jan 5, 2026

Uh oh!

Ikelene commented Jan 5, 2026

Uh oh!

cicerorph commented Jan 5, 2026 via email

Uh oh!

Ikelene commented Jan 5, 2026

Uh oh!

Ikelene commented Jan 28, 2026

Uh oh!

JeremyGamer13 commented Jan 28, 2026

Uh oh!

Gen1xLol commented Jan 28, 2026

Uh oh!

Ikelene commented Jan 28, 2026

Uh oh!

Ikelene commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel bot commented Dec 27, 2025 •

edited

Loading