Skip to content

Simplify model inspection and retain selectable OSA diagnostics - #19

Merged
PaulRegular merged 10 commits into
mainfrom
model-usability
Nov 4, 2026
Merged

PaulRegular merged 10 commits into
mainfrom
model-usability

Conversation

@PaulRegular

@PaulRegular PaulRegular commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Users can now inspect fitted models and retain explicitly calculated OSA residuals without navigating fit internals or refitting. This branch builds on the smooth warm-start CI repair in #18.

Changes:

  • Print concise input-validation summaries, with quiet internal calls; install dashboard R dependencies normally and check for Pandoc before rendering.
  • Select any of RTMB's five OSA algorithms with method, and retain method/settings/coverage using add_osa_residuals(). residuals() remains a pure table extractor; explicit controls recalculate catch and index together on temporary objectives.
  • Offer Auto / Standardized / OSA in public residual plots and dashboards. Auto selects separately by model/panel, preserves partial gaps, and keeps models without OSAs visible. Rendering never calculates OSAs implicitly.
  • Add get_ssb(), get_recruitment(), get_fbar(), get_mbar(), get_f() and get_m(), preserving uncertainty, units, projection flags and comparison labels.
  • Add plot_model(), a Model structure dashboard page and contrasting website examples linking stored settings to maintained equations.

Validation on final commit 0cb9a21:

  • Full suite: 4,540 assertions passed; zero failures, warnings or skips.
  • Local R CMD check --no-manual: Status OK.
  • GitHub: all five package-check platforms and coverage pass. Overall coverage 94.03%.
  • Fresh private-library installation and dashboard rendering passed with only the declared runtime dependency closure; no pkgload/testthat visible and no shared-library changes.
  • Mixed-model and two-fleet dashboards were rendered and exercised in the browser, including residual controls, model frames, partial OSAs and reference messages.
  • Home/reference/article documentation built; all 239 checked local links/anchors passed.

Limitations remain visible: some CI configurations retain the existing Rd Usage-line-width NOTE. The unchanged SAM-style teaching example reports false convergence, and a small requested OSA subset in the maintained random-walk example was unavailable; warnings and missing values were retained without tuning or algorithm switching.

Fitting specifications and controls are unchanged. No assessment exports were refreshed, version incremented or branches merged.

@PaulRegular
PaulRegular marked this pull request as ready for review November 4, 2026 04:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T04:57:18.937268Z 0cb9a21 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@PaulRegular
PaulRegular changed the base branch from ci-smooth-warm-starts to main November 4, 2026 10:26
@PaulRegular
PaulRegular merged commit 39d8413 into main Nov 4, 2026
6 checks passed
@PaulRegular
PaulRegular deleted the model-usability branch November 4, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant