Add item skill tooltips#2208
Draft
vaisest wants to merge 2 commits into
Draft
Conversation
--- New to Path of Building --- * Add 0.5.2 Passive tree changes (trompetin17) * Add support for very large time-lost jewel mod (vaisest) --- User Interface --- * Fix window title changing in compare tab (vaisest) --- Fixed Calculations --- * Fix many supports not adding cooldown (Peechey) * Fix calculation of inverted Resistances when having a source of Penetration (LocalIdentity) * Fix Discipline not being converted by Eldritch Battery (LocalIdentity) --- Fixed Behaviours --- * Fix Split Personality not working with Monk and Druid starting points (LocalIdentity) * Fix mods duplicating when crafting some Crossbows (LocalIdentity) * Fix Full DPS breakdown and gem dropdowns showing the wrong name for Companion / Spectre skills (ltogniolli) * Fix PoB Trader search not working correctly after comparing a build (vaisest) * Fix Mageblood mods merging in item crafter (LocalIdentity)
vaisest
force-pushed
the
item-skill-tooltips
branch
from
a07e61d to
bfb44a0
Compare
vaisest
changed the title
Contributor
Author
|
Sort of not a draft. I think this worked pretty well, and I couldn't find any remaining issues, but I wasn't sure if this was preferred over e.g. always showing it and having smarter tooltip logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds tooltips for item skills. Uses the level defined on the item. Displayitem not included, as it's not really a tooltip and would be weird to implement. Tooltips show when holding shift and are attached to the right of the item tooltip, and grow downwards. They will move over the main tooltip, which should be fine as the idea is that you can explicitly look at the skill, instead of it being e.g. shown at all times.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
Path.space.of.space.Building-PoE2_2026-06-15_22-46-18_1.mp4