Skip to content

Fix compare config tab controls not supporting selections #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaisest wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −1
Open

Fix compare config tab controls not supporting selections #2190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Classes/CompareTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2067,7 +2067,11 @@ local function syncControlValue(ctrl, varData, val)
ctrl.state = val or false
elseif varData.type == "count" or varData.type == "integer"
or varData.type == "countAllowZero" or varData.type == "float" then
ctrl:SetText(tostring(val or ""))
local text = tostring(val or "")
-- avoid setting text every time as otherwise this clears user selections on every frame
if text ~= ctrl.buf then
ctrl:SetText(text)
end
elseif varData.type == "list" then
ctrl:SelByValue(val or (varData.list[1] and varData.list[1].val), "val")
end
Expand Down
Loading