Skip to content

Fix PoB Trader search not working correctly after comparing a build #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Jun 13, 2026
+26 −25
Merged

Fix PoB Trader search not working correctly after comparing a build #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 26 additions & 25 deletions src/Classes/TradeQuery.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,31 +55,6 @@ local TradeQueryClass = newClass("TradeQuery", function(self, itemsTab)
self.lastQueries = {}

self.tradeQueryRequests = new("TradeQueryRequests")
local function onRateLimit(backoff)
self.backoffFinish = get_time() + backoff
self.countDown = coroutine.create(function()
while self.backoffFinish do
local now = get_time()
if self.backoffFinish < (now + 0.5) then
self.backoffFinish = nil
self:SetNotice(self.controls.pbNotice, "")
return
end
local msg = s_format("Rate limited. Retrying after %s seconds...", self.backoffFinish - now)
self:SetNotice(self.controls.pbNotice, colorCodes.WARNING..msg)
coroutine.yield()
end
end)
end
main.onFrameFuncs["TradeQueryRequests"] = function()
self.tradeQueryRequests:ProcessQueue(onRateLimit)
if self.countDown then
coroutine.resume(self.countDown)
if coroutine.status(self.countDown) == "dead" then
self.countDown = nil
end
end
end
if not main.api then
main.api = new("PoEAPI", main.lastToken, main.lastRefreshToken, main.tokenExpiry)
end
Expand Down Expand Up @@ -609,6 +584,32 @@ Highest Weight - Displays the order retrieved from trade]]
self.controls.scrollBar:SetContentDimension(self.pane_height-100, self.effective_rows_height)
self.controls.sectionAnchor.y = -self.controls.scrollBar.offset
end

local function onRateLimit(backoff)
self.backoffFinish = get_time() + backoff
self.countDown = coroutine.create(function()
while self.backoffFinish do
local now = get_time()
if self.backoffFinish < (now + 0.5) then
self.backoffFinish = nil
self:SetNotice(self.controls.pbNotice, "")
return
end
local msg = s_format("Rate limited. Retrying after %s seconds...", self.backoffFinish - now)
self:SetNotice(self.controls.pbNotice, colorCodes.WARNING..msg)
coroutine.yield()
end
end)
end
main.onFrameFuncs["TradeQueryRequests"] = function()
self.tradeQueryRequests:ProcessQueue(onRateLimit)
if self.countDown then
coroutine.resume(self.countDown)
if coroutine.status(self.countDown) == "dead" then
self.countDown = nil
end
end
end
main:OpenPopup(pane_width, self.pane_height, "Trader", self.controls, nil, nil, "close", (scrollBarShown and scrollBarFunc or nil))
end

Expand Down
Loading