Skip to content

Fix desecrate-only mods becoming monk glove mods#2174

Open
vaisest wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
vaisest:desecrate-parse
Open

Fix desecrate-only mods becoming monk glove mods#2174
vaisest wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
vaisest:desecrate-parse

Conversation

@vaisest

@vaisest vaisest commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Fixes false positive in item parsing which saved monk glove mods to the item affix IDs and which would cause them to appear when the item was recrafted (i.e. when a slider was moved)

Steps taken to verify a working solution:

  • Problem no longer happens
  • Monk gloves still parse as they used to

Link to a build that showcases this PR:

Item Class: Bows
Rarity: Rare
Rune Branch
Obliterator Bow
--------
Quality: +20% (augmented)
Physical Damage: 128-237 (augmented)
Elemental Damage: 76-120 (fire), 3-166 (lightning)
Critical Hit Chance: 8.47% (augmented)
Attacks per Second: 1.30 (augmented)
--------
Requires: Level 78, 163 Dex
--------
Sockets: S S 
--------
Item Level: 82
--------
Bow Attacks fire an additional Arrow (rune)
Gain 5% of Damage as Extra Damage of all Elements (rune)
--------
{ Implicit Modifier }
50% reduced Projectile Range
--------
{ Prefix Modifier "Cremating" (Tier: 2) — Damage, Elemental, Fire, Attack }
Adds 76(62-85) to 120(101-129) Fire Damage
{ Prefix Modifier "Electrocuting" (Tier: 2) — Damage, Elemental, Lightning, Attack }
Adds 3(1-10) to 166(157-196) Lightning Damage
{ Prefix Modifier "Emperor's" (Tier: 2) — Damage, Physical, Attack }
72(65-74)% increased Physical Damage
+169(150-174) to Accuracy Rating
{ Suffix Modifier "of the Sniper" (Tier: 1) }
+4 to Level of all Projectile Skills
{ Desecrated Suffix Modifier "of Amanamu" (Tier: 1) }
18(12-18)% increased Attack Speed
Companions have 18(12-18)% increased Attack Speed
{ Crafted Suffix Modifier "of Calamity" (Tier: 3) — Attack, Critical }
+3.47(3.11-3.8)% to Critical Hit Chance

Before:

Move a slider and desecrated mod will turn into a weird monk glove mod.

After:

Desecrated mod doesn't match anything and so becomes a custom mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant