Repository navigation
fix: fully consume release version smoke output - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result
Keep both exact-version release checks while avoiding an early-closing stdout pipe. No scan, attestation, source/image build, or publication gate is removed or relaxed. The signed
v0.9.28andv0.9.29tags remain immutable; this source candidate targets newv0.9.30.Evidence and narrow fix
The v0.9.29 Release run installed all pinned APK packages, verified and compiled HAProxy 3.4.3, and built the image successfully. The version-smoke section then failed with
write /dev/stdout: broken pipe. The log does not establish which of the two Docker commands encountered the early close, so neither is claimed as uniquely proven.Both existing checks pipe Docker stdout through
grep -Fqunderset -euo pipefail. A deterministic multi-write producer reproduces the oracle defect: the matching grep exits successfully while the still-writing producer exits 141. Capture each Docker command's complete stdout first, then run full-readinggrep -Fon the captured text. Assignment failures still terminate the step through the existingset -e.The adjacent
scripts/packagehas no analogous version-output pipe; it is unchanged. README truthfully records the retained failed tags and native QA pending.Validation
Tested the four actual changed workflow lines extracted into Bash, with deterministic multi-write Docker fixtures:
bash -nof the actual smoke section andgit diff --check: PASS.No unrelated test suite was rerun locally. Native PastureStack load-balancer QA remains pending. No QA/production runtime or other repository was modified.