Add optional pageType parameter to ParselyMetadata class in Android SDK#103
Closed
MartinAkram wants to merge 5 commits intorelease/3.2.0from
Closed
Add optional pageType parameter to ParselyMetadata class in Android SDK#103MartinAkram wants to merge 5 commits intorelease/3.2.0from
pageType parameter to ParselyMetadata class in Android SDK#103MartinAkram wants to merge 5 commits intorelease/3.2.0from
Conversation
wzieba
reviewed
Jan 23, 2024
Comment on lines
+42
to
+43
| @Nullable Calendar pubDate, | ||
| @Nullable String pageType |
Collaborator
There was a problem hiding this comment.
hi @MartinAkram 👋 Instead of modifying the constructor, can we add a new one? This way we won't introduce a breaking change for the clients. Something like in this commit 8996f50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional parameter,
pageType, to theParselyMetadataclass in the Android SDK. This is being done in response to a client question/request (see linked issue below).Companion iOS SDK PR: Parsely/AnalyticsSDK-iOS#90
🤔 Why 🤔
Resolves https://github.com/Parsely/web/issues/13450
✔️ TODOs ✔️