I mean, overall I initially expected the behavior to be
final long catchup = 1L + io.papermc.paper.configuration.GlobalConfiguration.get().misc.catchupTicks.or(4);
instead of
final long catchup = (long)Math.max(
1,
io.papermc.paper.configuration.GlobalConfiguration.get().misc.catchupTicks.or(5)
);
when I first saw that option. That said, if this is the intended behavior, it would be good to document that the minimum effective enabled value is 2, or at least mention that setting it to 1 is equivalent to 0.
Also, if 0 is meant to represent disabled, it's fairly intuitive to expect 1 to be the minimum enabled value. A user might intentionally configure it to 1 because they want the smallest possible non-disabled setting, so having it behave the same as 0 is somewhat surprising unless it's explicitly documented.
I mean, overall I initially expected the behavior to be
instead of
when I first saw that option. That said, if this is the intended behavior, it would be good to document that the minimum effective enabled value is
2, or at least mention that setting it to1is equivalent to0.Also, if
0is meant to represent disabled, it's fairly intuitive to expect1to be the minimum enabled value. A user might intentionally configure it to1because they want the smallest possible non-disabled setting, so having it behave the same as0is somewhat surprising unless it's explicitly documented.