Repository navigation
Preserve timestamps when stripping jar signatures - #67
Merged
Merged
Conversation
Copy the jar with ZipFile and ZipOutputStream instead of zipfs, so entries keep their original timestamps and order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches
StripSignaturesPagefrom zipfs toZipFileandZipOutputStream, so entries in the stripped jar keep their original timestamps and order.Jars with duplicate entry names now fail with a
ZipExceptioninstead of being collapsed by zipfs. This is intentional.Testing
./gradlew checkpasses. No tests were added.I also ran the CLI on Minecraft 26.1.2 and compared the signed server jar with the stripped one:
META-INF/MOJANGCS.RSAandMETA-INF/MOJANGCS.SFwere removed.META-INF/MANIFEST.MFchanged: its digest lines are gone andMain-Classis kept.Every entry in that jar is DEFLATED, so the path that rewrites a STORED manifest has not been exercised.