Fix duplicate player cookie requests - #14274
Closed
HP-network wants to merge 1 commit into
Closed
HP-network wants to merge 1 commit into
HP-network wants to merge 1 commit into
Conversation
Member
|
Already exists a PR for that issue. #14245 For the future you can check the references in the issue for make sure if exists a PR related to. |
Author
|
Closing this in favor of the existing implementation in #14245. |
github-project-automation
Bot
moved this from Awaiting review
to Closed
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14211
retrieveCookiecurrently stores one pending future per cookie key, so a second request replaces the first and the first future never completes. Keep a FIFO queue per key and consume one pending request for each response. Requests for different keys remain independent.Validation:
./gradlew :paper-server:applyPatches :paper-server:compileJava --no-daemon.