Fix yaw wraparound in movement event checks - #14262
Open
HP-network wants to merge 1 commit into
Open
HP-network wants to merge 1 commit into
HP-network wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14222
When checking whether a
PlayerMoveEventshould be fired, normalize the yaw difference before taking its absolute value. A packet transition from180to-180represents the same orientation, but the raw subtraction reports a 360-degree change and can repeatedly trigger a cancelled event and teleport loop.This applies the normalized comparison in both movement-event checks.
Testing:
./gradlew :paper-server:applySourcePatches --no-daemon --console=plain./gradlew :paper-server:compileJava --no-daemon --console=plain180/-180transitions:paper-server:testreaches test compilation but is blocked by the existingPredicateChoiceMatchingTestAPI mismatch; the same errors occur on the unmodified baseline