Handle surface lava in anti-xray - #14257
Open
OfficialTheosis wants to merge 1 commit into
Open
OfficialTheosis wants to merge 1 commit into
OfficialTheosis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Problem
The
lava-obscuresanti-xray setting currently makes it so that source lava is simply treated as an obscuring block. The problem with this is that surface lava does not completely visually cover blocks horizontally adjacent to or above it, meaning if the setting is enabled, these blocks can be obscured by the anti-xray even though they are visible to the player, resulting in obvious visual artefacts, particularly around the edges of lava lakes.As a server owner, I want to be able to prevent players from being able to trivially locate hidden blocks such as ancient debris under large lava lakes in the nether by simply turning off lava fog and flying through them with an elytra and fire resistance. The
lava-obscuressetting provides a means to this, but the aforementioned visual artefacts it results in makes enabling it much less desirable.New Behaviour
This PR makes it so that if
lava-obscuresis enabled:Testing
I did what I believe to be a good amount of testing, and I wasn't able to find any broken behaviour or noticeable performance regressions (I'm happy to perform any additional testing as required). These are the results of my testing:
lava-obscuressetting disabled is unaffected.AI Assistance