feat: remove name field in Event class - #14198
Merged
Merged
Conversation
NonSwag
approved these changes
Aug 20, 2026
papermc-projects
Bot
moved this from Awaiting review
to Delayed approval
in Paper PR Queue
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
SirYwell
approved these changes
Aug 20, 2026
kennytv
approved these changes
Aug 20, 2026
github-project-automation
Bot
moved this from Full approval
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially discovered by @SirYwell, the
Eventclass currently holds aString namefield that is only used to cache the output ofgetClass().getSimpleName().However, that
getSimpleName()method itself is already cached as part of the class' reflection data, making this manual cache mostly a waste of 4/8 bytes of memory.Additionally, in server code, the
getEventName()method is only called once in error messages, and thus the cache may not even live to see any effect.For a class as frequently constructed, the memory save here can be seen as significant.