Add ItemSpawnEntityEvent and BlockPlaceEntityEvent and EntityPlaceEvent#13665
Open
Machine-Maker wants to merge 2 commits intoPaperMC:mainfrom
Open
Add ItemSpawnEntityEvent and BlockPlaceEntityEvent and EntityPlaceEvent#13665Machine-Maker wants to merge 2 commits intoPaperMC:mainfrom
Machine-Maker wants to merge 2 commits intoPaperMC:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4795
Resolves #6898
Resolves #13302
Supersedes #4184
Replaces #7377
Changes
Adds ItemSpawnEntityEvent
Adds PlaceEntityEvent (extends ItemSpawnEntityEvent)
Adds BlockPlaceEntityEvent (extends PlaceEntityEvent)
Makes EntityPlaceEvent extend PlaceEntityEvent
Added an ItemStack field on ItemSpawnEntityEvent since that applies to all uses of that event and EntityPlaceEvent.
New Event Calls
ItemSpawnEntityEvent
EntityPlaceEvent (player only)
BlockPlaceEntityEvent (dispenser only)
Entity Placements
Item Frame, Painting, Leash(HangingPlaceEvent) (can't change due to API break)Fireworksalready tracks its spawning stack and shooterFire Chargesalready tracks its spawning stack and shooter